Skip to content

Show manage models action in the search input #300165

Merged
sandy081 merged 9 commits intomainfrom
sandy081/copilot/precise-orca
Mar 9, 2026
Merged

Show manage models action in the search input #300165
sandy081 merged 9 commits intomainfrom
sandy081/copilot/precise-orca

Conversation

@sandy081
Copy link
Member

@sandy081 sandy081 commented Mar 9, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 9, 2026 11:58
@sandy081 sandy081 changed the title Merging sandy081/copilot/precise-orca to main Show manage models action in the search input Mar 9, 2026
@sandy081 sandy081 self-assigned this Mar 9, 2026
@sandy081 sandy081 enabled auto-merge (squash) March 9, 2026 11:59
@sandy081 sandy081 added this to the 1.112.0 milestone Mar 9, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the chat model picker and the underlying action widget list to support showing an optional “Manage Models” action inline with the filter input (instead of always as a list item), improving discoverability when the picker has many models.

Changes:

  • Add support for optional filterActions in ActionList and render them next to the filter input.
  • Adjust model picker behavior to show “Manage Models” as a filter-row action when filtering is enabled, otherwise as a list entry.
  • Add CSS to lay out and style the new filter row actions.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/vs/workbench/contrib/chat/browser/widget/input/chatModelPicker.ts Refactors “Manage Models” into a reusable action and conditionally places it either in the list or in filter-row actions.
src/vs/platform/actionWidget/browser/actionWidget.css Adds layout/styling for a filter row with right-aligned actions.
src/vs/platform/actionWidget/browser/actionList.ts Extends action list options with filterActions and renders an action bar in the filter row.
Comments suppressed due to low confidence (1)

src/vs/workbench/contrib/chat/browser/widget/input/chatModelPicker.ts:375

  • The Manage Models entry is now only added when manageModelsAction is passed. Existing callers that rely on buildModelPickerItems to include the Manage Models item based on entitlement (e.g. the current unit tests in chatModelPicker.test.ts) will stop seeing it and will fail. Either update all call sites/tests to pass manageModelsAction, or keep the previous internal entitlement-based fallback in buildModelPickerItems (and add an explicit option to suppress it when the filter-row action is used).
	if (manageModelsAction) {
		items.push({ kind: ActionListItemKind.Separator, section: otherModels.length ? ModelPickerSection.Other : undefined });
		items.push({
			item: manageModelsAction,
			kind: ActionListItemKind.Action,
			label: manageModelsAction.label,
			group: { title: '', icon: Codicon.blank },
			hideIcon: false,
			section: otherModels.length ? ModelPickerSection.Other : undefined,
			showAlways: true,
		});

chrmarti
chrmarti previously approved these changes Mar 9, 2026
@sandy081 sandy081 merged commit 4a4e662 into main Mar 9, 2026
18 of 19 checks passed
@sandy081 sandy081 deleted the sandy081/copilot/precise-orca branch March 9, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants