Show manage models action in the search input #300165
Merged
Conversation
…e models action handling
…ntries and streamline manage models action handling
…rove action management
…e additional entry handling
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the chat model picker and the underlying action widget list to support showing an optional “Manage Models” action inline with the filter input (instead of always as a list item), improving discoverability when the picker has many models.
Changes:
- Add support for optional
filterActionsinActionListand render them next to the filter input. - Adjust model picker behavior to show “Manage Models” as a filter-row action when filtering is enabled, otherwise as a list entry.
- Add CSS to lay out and style the new filter row actions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/input/chatModelPicker.ts | Refactors “Manage Models” into a reusable action and conditionally places it either in the list or in filter-row actions. |
| src/vs/platform/actionWidget/browser/actionWidget.css | Adds layout/styling for a filter row with right-aligned actions. |
| src/vs/platform/actionWidget/browser/actionList.ts | Extends action list options with filterActions and renders an action bar in the filter row. |
Comments suppressed due to low confidence (1)
src/vs/workbench/contrib/chat/browser/widget/input/chatModelPicker.ts:375
- The Manage Models entry is now only added when
manageModelsActionis passed. Existing callers that rely onbuildModelPickerItemsto include the Manage Models item based on entitlement (e.g. the current unit tests inchatModelPicker.test.ts) will stop seeing it and will fail. Either update all call sites/tests to passmanageModelsAction, or keep the previous internal entitlement-based fallback inbuildModelPickerItems(and add an explicit option to suppress it when the filter-row action is used).
if (manageModelsAction) {
items.push({ kind: ActionListItemKind.Separator, section: otherModels.length ? ModelPickerSection.Other : undefined });
items.push({
item: manageModelsAction,
kind: ActionListItemKind.Action,
label: manageModelsAction.label,
group: { title: '', icon: Codicon.blank },
hideIcon: false,
section: otherModels.length ? ModelPickerSection.Other : undefined,
showAlways: true,
});
src/vs/workbench/contrib/chat/browser/widget/input/chatModelPicker.ts
Outdated
Show resolved
Hide resolved
chrmarti
previously approved these changes
Mar 9, 2026
…nd use manageModelsAction instead
benibenj
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.