Move registerChatModelChangeListeners onto chat service#300288
Merged
mjbvz merged 2 commits intomicrosoft:mainfrom Mar 10, 2026
Merged
Move registerChatModelChangeListeners onto chat service#300288mjbvz merged 2 commits intomicrosoft:mainfrom
registerChatModelChangeListeners onto chat service#300288mjbvz merged 2 commits intomicrosoft:mainfrom
Conversation
No sure what this method was doing on the sessions service. Really should be deleted entirely but moving to a better home on the chat service as a first step
Contributor
There was a problem hiding this comment.
Pull request overview
This PR relocates registerChatModelChangeListeners from the chat sessions service to the chat service, aligning ownership of model-change observation with the service that manages chat models.
Changes:
- Removed
registerChatModelChangeListenersfromIChatSessionsServiceand theChatSessionsServiceimplementation. - Added
registerChatModelChangeListenerstoIChatServiceand implemented it inChatService. - Updated call sites and test mocks to use the new
IChatServiceentry point.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/common/mockChatSessionsService.ts | Drops the old sessions-service test hook for model-change listeners. |
| src/vs/workbench/contrib/chat/test/common/chatService/mockChatService.ts | Adds a test hook to the chat-service mock for triggering model-change callbacks. |
| src/vs/workbench/contrib/chat/test/browser/agentSessions/localAgentSessionsController.test.ts | Updates tests to trigger change callbacks via the chat-service mock instead of sessions service. |
| src/vs/workbench/contrib/chat/common/chatSessionsService.ts | Removes the registerChatModelChangeListeners API from IChatSessionsService. |
| src/vs/workbench/contrib/chat/common/chatService/chatServiceImpl.ts | Adds the moved registerChatModelChangeListeners implementation onto ChatService. |
| src/vs/workbench/contrib/chat/common/chatService/chatService.ts | Adds the new (deprecated) IChatService.registerChatModelChangeListeners signature. |
| src/vs/workbench/contrib/chat/browser/chatSessions/chatSessions.contribution.ts | Removes the ChatSessionsService.registerChatModelChangeListeners implementation and related imports. |
| src/vs/workbench/contrib/chat/browser/agentSessions/localAgentSessionsController.ts | Switches listener registration to chatService.registerChatModelChangeListeners(...). |
| src/vs/workbench/api/browser/mainThreadChatSessions.ts | Switches listener registration to chatService.registerChatModelChangeListeners(...). |
joshspicer
previously approved these changes
Mar 9, 2026
DonJayamanne
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure what this method was doing on the sessions service. Really should be deleted entirely but moving to a better home on the chat service as a first step