ci and PR review comments in agent feedback#300444
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds GitHub-backed PR metadata into the Agent Sessions window so the agent feedback overlay can surface PR review comments (in addition to existing agent feedback + code review comments) and show PR CI check status in the Changes view.
Changes:
- Introduces a new
IGitHubService(+ API client, fetchers, reactive models) for GitHub repo/PR/CI data. - Extends
CodeReviewService+ agent feedback UI plumbing to fetch, display, navigate, and “resolve” PR review threads. - Adds a collapsible CI status widget under the Changes view and integrates comment counts across sources.
Reviewed changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/sessions.desktop.main.ts | Wires up the new GitHub contribution to the sessions desktop entrypoint. |
| src/vs/sessions/contrib/sessions/browser/sessionsManagementService.ts | Adds helpers to derive GitHub PR context and resolve session-relative file URIs. |
| src/vs/sessions/contrib/github/common/types.ts | Defines GitHub domain types used across the sessions GitHub feature. |
| src/vs/sessions/contrib/github/browser/github.contribution.ts | Registers the GitHub service singleton. |
| src/vs/sessions/contrib/github/browser/githubService.ts | Implements cached GitHub repository/PR/CI reactive models. |
| src/vs/sessions/contrib/github/browser/githubApiClient.ts | Implements authenticated REST/GraphQL client for GitHub APIs. |
| src/vs/sessions/contrib/github/browser/fetchers/githubRepositoryFetcher.ts | REST fetcher for repository metadata. |
| src/vs/sessions/contrib/github/browser/fetchers/githubPRFetcher.ts | REST/GraphQL fetcher for PR info, mergeability, review threads, and mutations. |
| src/vs/sessions/contrib/github/browser/fetchers/githubPRCIFetcher.ts | REST fetcher for check runs and check-run output/annotations; computes overall status. |
| src/vs/sessions/contrib/github/browser/models/githubRepositoryModel.ts | Observable repository model with refresh + error logging. |
| src/vs/sessions/contrib/github/browser/models/githubPullRequestModel.ts | Observable PR model with refresh, posting comments, resolving threads, and polling. |
| src/vs/sessions/contrib/github/browser/models/githubPullRequestCIModel.ts | Observable CI model for PR head ref with refresh and polling. |
| src/vs/sessions/contrib/github/test/browser/githubService.test.ts | Unit tests for model caching; includes basic parsing-related checks. |
| src/vs/sessions/contrib/github/test/browser/githubModels.test.ts | Unit tests for repository/PR/CI models behavior with mock fetchers. |
| src/vs/sessions/contrib/github/test/browser/githubFetchers.test.ts | Unit tests for fetcher mappings, GraphQL usage, and CI overall status computation. |
| src/vs/sessions/contrib/codeReview/browser/codeReviewService.ts | Adds PR review state + thread resolution APIs and wiring to GitHub service/models. |
| src/vs/sessions/contrib/codeReview/test/browser/codeReviewService.test.ts | Updates test setup to stub new dependencies (log, GitHub, sessions management). |
| src/vs/sessions/contrib/codeReview/browser/codeReview.contributions.ts | Updates toolbar/action behavior to include PR review comments in navigation/counts. |
| src/vs/sessions/contrib/changes/browser/media/ciStatusWidget.css | Adds styling for the new CI status widget. |
| src/vs/sessions/contrib/changes/browser/ciStatusWidget.ts | Implements the CI status widget UI + “Fix Checks” action integration with chat. |
| src/vs/sessions/contrib/changes/browser/changesView.ts | Integrates PR review comment counts and binds the CI status widget to active session PR. |
| src/vs/sessions/contrib/agentFeedback/browser/sessionEditorComments.ts | Adds PR review as a new session comment source and includes it in comment aggregation. |
| src/vs/sessions/contrib/agentFeedback/test/browser/sessionEditorComments.test.ts | Adds coverage for PR review comments being included/ordered/omitted. |
| src/vs/sessions/contrib/agentFeedback/test/browser/agentFeedbackEditorWidget.fixture.ts | Adds fixtures to render PR review-only and mixed-source comment states. |
| src/vs/sessions/contrib/agentFeedback/browser/media/agentFeedbackEditorWidget.css | Adds PR review styling for the agent feedback overlay items. |
| src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackService.ts | Updates navigation to open modal editors/diffs and handle deletions appropriately. |
| src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorWidgetContribution.ts | Plumbs PR review state into widget rebuild + adjusts comment matching for diff resources. |
| src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorOverlay.ts | Includes PR review comments when computing navigation bearings. |
| src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorActions.ts | Uses unified reveal logic (modal/diff-aware) when navigating comments. |
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
aeschli
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot Generated Description:Add support for fetching and displaying PR review comments in the agent feedback overlay. Introduce a new GitHub service for repository data and update styles for PR review items. Update session editor comments to include PR review comments alongside existing agent feedback and code review comments.