Revert "Revert "Debug Panel: oTel data source support and Import/export (#299256)"" by vijayupadya · Pull Request #300477 · microsoft/vscode

vijayupadya · 2026-03-10T16:32:44Z

…rt (#299…" This reverts commit 1124601.

github-actions · 2026-03-10T16:34:16Z

⚠️ API Proposal Version Change Detected

The following proposed API files have version changes: vscode.proposed.chatDebug.d.ts

API proposal version changes should only be used when maintaining compatibility is not possible. Consider keeping the version as is and maintaining backward compatibility.

Any version changes must be adopted by the consuming extensions before the next insiders for the extension to work.

If the version change is required, comment /api-proposal-change-required to unblock this check and acknowledge that you will update any critical consuming extensions (Copilot Chat).

vijayupadya · 2026-03-10T16:36:05Z

/api-proposal-change-required

Copilot

Pull request overview

This PR (despite the “revert” title/description) re-introduces and extends the Chat Debug proposed API and workbench integration to support exporting/importing agent debug logs, along with several UX improvements in the debug panel.

Changes:

Add proposed API surface for exporting/importing chat debug logs (and bump the proposal version).
Implement export/import plumbing across main thread ↔ extension host, and add UI actions to trigger export/import from the Agent Debug Panel.
Improve debug panel rendering (log ordering/refresh scheduling, session titles, flow graph labels).

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/vscode-dts/vscode.proposed.chatDebug.d.ts	Bumps proposal version and adds proposed API types/methods for debug log export/import.
src/vs/platform/extensions/common/extensionsApiProposals.ts	Updates the `chatDebug` proposal version to match the d.ts bump.
src/vs/workbench/contrib/chat/common/chatDebugService.ts	Extends `IChatDebugService`/provider interfaces with export/import + imported session metadata helpers.
src/vs/workbench/contrib/chat/common/chatDebugServiceImpl.ts	Implements export/import, core-vs-provider event detection, and imported session tracking.
src/vs/workbench/api/common/extHost.protocol.ts	Adds RPC methods for export/import.
src/vs/workbench/api/common/extHostChatDebug.ts	Implements ext host RPC handlers and DTO→API event deserialization for export options.
src/vs/workbench/api/browser/mainThreadChatDebug.ts	Implements main thread provider wiring for export/import, passing core events + session title.
src/vs/workbench/contrib/chat/browser/actions/chatOpenAgentDebugPanelAction.ts	Adds “Export/Import Agent Debug Log…” actions and file dialog integration.
src/vs/workbench/contrib/chat/browser/chatDebug/chatDebugEditor.ts	Adjusts editor visibility handling and auto-navigation when a new session is created.
src/vs/workbench/contrib/chat/browser/chatDebug/chatDebugLogsView.ts	Maintains chronological ordering via binary insertion and batches refreshes with a scheduler.
src/vs/workbench/contrib/chat/browser/chatDebug/chatDebugHomeView.ts	Refines session title selection for local vs imported sessions.
src/vs/workbench/contrib/chat/browser/chatDebug/chatDebugFlowLayout.ts	Avoids duplicating subagent description in subgraph headers.
src/vs/workbench/contrib/chat/browser/chatDebug/chatDebugFlowGraph.ts	Improves subagent labeling and event label/sublabel behavior.

Copilot · 2026-03-10T16:39:33Z

src/vs/workbench/contrib/chat/common/chatDebugService.ts

 	resolveEvent(eventId: string): Promise<IChatDebugResolvedEventContent | undefined>;

+	/**
+	/**


The JSDoc for the new export/import methods has an extra opening /** which will break the comment formatting (and can confuse doc tooling). Remove the stray opening so there is a single well-formed JSDoc block for exportLog.

Suggested change

/**

Copilot · 2026-03-10T16:39:34Z

src/vs/workbench/contrib/chat/common/chatDebugServiceImpl.ts

+	/** Session URIs created via import, allowed through the invokeProviders guard. */
+	private readonly _importedSessions = new ResourceMap<boolean>();
+
+	/** Human-readable titles for imported sessions. */
+	private readonly _importedSessionTitles = new ResourceMap<string>();


Imported sessions/titles are tracked in _importedSessions/_importedSessionTitles, but these maps are never cleared (not in clear(), endSession(), or dispose()). Over time this can grow without bound in long-running windows. Consider deleting entries for a session in endSession() (and/or clearing both maps in clear()/dispose()) when an imported session is no longer needed.

Copilot · 2026-03-10T16:39:34Z

src/vs/workbench/api/common/extHostChatDebug.ts

+				evt.inputTokens = dto.inputTokens;
+				evt.outputTokens = dto.outputTokens;
+				evt.totalTokens = dto.totalTokens;
+				evt.durationInMillis = dto.durationInMillis;


_deserializeEvent drops requestName (and any other model-turn metadata present on the DTO) when reconstructing ChatDebugModelTurnEvent. As a result, extensions exporting core events via coreEvents won’t receive requestName even though it’s serialized on the main thread. Preserve the DTO fields on the reconstructed event (and add the corresponding properties to the event type if needed).

Suggested change

evt.durationInMillis = dto.durationInMillis;

evt.durationInMillis = dto.durationInMillis;

// Preserve any additional model-turn metadata present on the DTO (for example, requestName)

for (const key in dto as any) {

if (!(key in (evt as any))) {

(evt as any)[key] = (dto as any)[key];

}

}

Copilot · 2026-03-10T16:39:35Z

src/vs/workbench/contrib/chat/browser/actions/chatOpenAgentDebugPanelAction.ts

+			const result = await fileDialogService.showOpenDialog({
+				defaultUri,
+				canSelectFiles: true,
+				filters: debugLogFilters
+			});
+			if (!result) {
+				return;
+			}
+
+			const content = await fileService.readFile(result[0]);
+			const sessionUri = await chatDebugService.importLog(content.value.buffer);


showOpenDialog can return an empty array (not just undefined). The current check only guards undefined, but then result[0] is used unconditionally. Please also guard result.length > 0 before reading result[0] to avoid an out-of-bounds access.

Copilot · 2026-03-10T16:39:35Z

src/vs/workbench/contrib/chat/browser/chatDebug/chatDebugEditor.ts

+			// ensuring correct ordering and no stale duplicates.
+			// Navigation from new openEditor() options is handled by
+			// setOptions → _applyNavigationOptions (fires after this).
+			this.showView(this.viewState);


setEditorVisible(false) no longer stops the active session pipeline (endActiveSession()), even though endActiveSession’s comment says it’s called when the editor becomes hidden. This can leave provider streaming running while the panel is hidden and makes the comment inaccurate. Either re-introduce cancelling on hide (if that’s still desired) or update the comment/ensure background work is acceptable.

Suggested change

this.showView(this.viewState);

this.showView(this.viewState);

} else {

// When the editor is hidden, end the active session so any ongoing

// provider pipelines/streaming are cancelled.

this.endActiveSession();

vijayupadya · 2026-03-10T16:46:34Z

/api-proposal-change-required

vijayupadya · 2026-03-10T16:52:52Z

⚠️ API Proposal Version Change Detected

The following proposed API files have version changes: vscode.proposed.chatDebug.d.ts

API proposal version changes should only be used when maintaining compatibility is not possible. Consider keeping the version as is and maintaining backward compatibility.

Any version changes must be adopted by the consuming extensions before the next insiders for the extension to work.

If the version change is required, comment /api-proposal-change-required to unblock this check and acknowledge that you will update any critical consuming extensions (Copilot Chat).

/api-proposal-change-required

Needed to unblock microsoft#300477

Revert "Revert "Debug Panel: oTel data source support and Import/expo…

fc39a46

…rt (#299…" This reverts commit 1124601.

Copilot AI review requested due to automatic review settings March 10, 2026 16:32

pwang347 approved these changes Mar 10, 2026

View reviewed changes

Copilot started reviewing on behalf of vijayupadya March 10, 2026 16:34 View session

vijayupadya marked this pull request as ready for review March 10, 2026 16:34

vijayupadya enabled auto-merge (squash) March 10, 2026 16:34

vs-code-engineering bot assigned vijayupadya Mar 10, 2026

vs-code-engineering bot added this to the 1.112.0 milestone Mar 10, 2026

Copilot AI reviewed Mar 10, 2026

View reviewed changes

Merge branch 'main' into revert-300381-sandy081/immediate-flea

4cf41df

mjbvz added a commit to mjbvz/vscode that referenced this pull request Mar 10, 2026

Disable api-version-check for now

0cd1e59

Needed to unblock microsoft#300477

mjbvz mentioned this pull request Mar 10, 2026

Disable api-version-check for now #300495

Merged

vijayupadya merged commit 34bfd71 into main Mar 10, 2026
19 of 20 checks passed

vijayupadya deleted the revert-300381-sandy081/immediate-flea branch March 10, 2026 17:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "Revert "Debug Panel: oTel data source support and Import/export (#299256)""#300477

Revert "Revert "Debug Panel: oTel data source support and Import/export (#299256)""#300477
vijayupadya merged 2 commits intomainfrom
revert-300381-sandy081/immediate-flea

vijayupadya commented Mar 10, 2026

Uh oh!

github-actions bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

vijayupadya commented Mar 10, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 10, 2026

Uh oh!

Copilot AI Mar 10, 2026

Uh oh!

Copilot AI Mar 10, 2026

Uh oh!

Copilot AI Mar 10, 2026

Uh oh!

Copilot AI Mar 10, 2026

Uh oh!

vijayupadya commented Mar 10, 2026

Uh oh!

vijayupadya commented Mar 10, 2026

⚠️ API Proposal Version Change Detected

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

-				evt.durationInMillis = dto.durationInMillis;
+				evt.durationInMillis = dto.durationInMillis;
+				// Preserve any additional model-turn metadata present on the DTO (for example, requestName)
+				for (const key in dto as any) {
+					if (!(key in (evt as any))) {
+						(evt as any)[key] = (dto as any)[key];
+					}
+				}

-			this.showView(this.viewState);
+			this.showView(this.viewState);
+		} else {
+			// When the editor is hidden, end the active session so any ongoing
+			// provider pipelines/streaming are cancelled.
+			this.endActiveSession();

Conversation

vijayupadya commented Mar 10, 2026

Uh oh!

github-actions bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ API Proposal Version Change Detected

Uh oh!

vijayupadya commented Mar 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

vijayupadya commented Mar 10, 2026

Uh oh!

vijayupadya commented Mar 10, 2026

⚠️ API Proposal Version Change Detected

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Mar 10, 2026 •

edited

Loading