Fix source path duplication in NLS plugin source maps and add corresponding test#300487
Merged
Fix source path duplication in NLS plugin source maps and add corresponding test#300487
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the NLS esbuild plugin where source map paths for files in nested directories were incorrectly duplicated (e.g., nested/deep/nested/deep/file.ts instead of nested/deep/file.ts). The issue occurred because the inline source map generated by the NLS plugin used the full repo-relative path as the source name, which esbuild then resolved relative to the file's own directory, causing the directory segments to appear twice in the final bundled source map.
Changes:
- Changed
sourceNamein the NLS plugin from the full relative path to justpath.basename(args.path), preventing esbuild from double-resolving directory segments. - Added a regression test that bundles a file in a nested directory (
nested/deep/file.ts) and verifies the source map path is not duplicated.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
build/next/nls-plugin.ts |
Changed sourceName from repo-relative path to path.basename(args.path) to fix source map path duplication |
build/next/test/nls-sourcemap.test.ts |
Added regression test verifying nested file source paths are not duplicated in the source map |
DonJayamanne
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.