Skip to content

Disable api-version-check for now #300495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjbvz merged 1 commit into from
Mar 10, 2026
Merged

Disable api-version-check for now #300495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/api-proposal-version-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@ jobs:
check-version-changes:
name: Check API Proposal Version Changes
# Run on PR events, or on issue_comment if it's on a PR and contains the override command
if: |
github.event_name == 'pull_request' ||
(github.event_name == 'issue_comment' &&
github.event.issue.pull_request &&
contains(github.event.comment.body, '/api-proposal-change-required'))
if: false # temporarily disabled
# github.event_name == 'pull_request' ||
# (github.event_name == 'issue_comment' &&
# github.event.issue.pull_request &&
# contains(github.event.comment.body, '/api-proposal-change-required'))
Comment on lines +26 to +30
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting if: false skips the job entirely (conclusion becomes “skipped/neutral”), which won’t satisfy branch protection if this workflow/job is configured as a required check. If the goal is to unblock merges while disabling the enforcement, consider keeping the job running and exiting successfully with a short no-op step, or adjust branch protection/required checks in tandem with this change.

Suggested change
if: false # temporarily disabled
# github.event_name == 'pull_request' ||
# (github.event_name == 'issue_comment' &&
# github.event.issue.pull_request &&
# contains(github.event.comment.body, '/api-proposal-change-required'))
if: github.event_name == 'pull_request' ||
(github.event_name == 'issue_comment' &&
github.event.issue.pull_request &&
contains(github.event.comment.body, '/api-proposal-change-required'))

Copilot uses AI. Check for mistakes.
Comment on lines +26 to +30
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commented-out original condition is currently indented under the if: false line, which reads a bit like a YAML continuation. For readability, consider dedenting these comments to the same level as if: (or moving them above) so it’s clear they’re just reference comments and not part of the YAML structure.

Suggested change
if: false # temporarily disabled
# github.event_name == 'pull_request' ||
# (github.event_name == 'issue_comment' &&
# github.event.issue.pull_request &&
# contains(github.event.comment.body, '/api-proposal-change-required'))
# github.event_name == 'pull_request' ||
# (github.event_name == 'issue_comment' &&
# github.event.issue.pull_request &&
# contains(github.event.comment.body, '/api-proposal-change-required'))
if: false # temporarily disabled

Copilot uses AI. Check for mistakes.
runs-on: ubuntu-latest
steps:
- name: Get PR info
Expand Down
Loading