Merged
Conversation
All of our extensions are now using esbuild
Contributor
There was a problem hiding this comment.
Pull request overview
This PR completes the removal of webpack from the built-in extensions build/packaging pipeline (now esbuild-only), while ensuring the Monaco test packaging step still has its own local webpack toolchain.
Changes:
- Remove webpack-based extension packaging/build support from
build/lib/extensions.tsandbuild/gulpfile.extensions.ts. - Drop shared webpack configuration and the (currently disabled) mangling loader from
extensions/. - Move webpack (and required loaders) into
test/monacoso the Monaco “Package Editor with Webpack” workflow remains functional after root-level webpack deps are removed.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/monaco/package.json | Uses local webpack binary and adds required webpack-related devDependencies for Monaco packaging. |
| test/monaco/package-lock.json | Locks the new Monaco-local webpack toolchain dependency graph. |
| package.json | Removes webpack-related devDependencies now that extensions no longer use webpack. |
| package-lock.json | Removes webpack-related packages from the root lockfile to match package.json. |
| extensions/shared.webpack.config.mjs | Deleted shared webpack config previously used by extensions. |
| extensions/mangle-loader.js | Deleted webpack loader previously used for (disabled) mangling. |
| build/lib/extensions.ts | Removes webpack packaging path; esbuild-only bundling remains. |
| build/gulpfile.extensions.ts | Stops discovering/running webpack configs for web extensions; esbuild-only. |
Files not reviewed (1)
- test/monaco/package-lock.json: Language not supported
rzhao271
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of our extensions are now using esbuild