Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes small UX/behavior tweaks in the Sessions window: it adjusts when the “Run Code Review” action is shown and improves focus/selection-change handling when submitting agent feedback from the editor overlay widget.
Changes:
- Hide the Sessions “Run Code Review” toolbar action for Cloud agent sessions.
- Add a one-time selection-change suppression mechanism to prevent the feedback widget from re-opening during hide/refocus.
- Refactor feedback submission flows to share a single hide+refocus helper.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/sessions/contrib/codeReview/browser/codeReview.contributions.ts | Adds a context key constraint so the code review action is not offered for Cloud agent sessions. |
| src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorInputContribution.ts | Introduces one-shot selection-change suppression and centralizes hide+refocus logic after feedback actions. |
You can also share your feedback on Copilot code review. Take the survey.
src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorInputContribution.ts
Show resolved
Hide resolved
mjbvz
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot Generated Description:Introduce a mechanism to suppress selection changes temporarily and refactor the feedback submission process to improve focus handling in the editor. Additionally, update the session code review action to exclude certain agent session types.