Sessions - changes view improvements#300780
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves the Agent Sessions “Changes” view (vs/sessions) by refining reactive git/repository tracking and by wiring additional context keys intended to drive toolbar/menu enablement/visibility.
Changes:
- Refactors active-session repository tracking to resolve
IGitRepositoryviaObservablePromiserather than nestedobservableFromPromisevalues. - Adds/binds new context keys for merge-base branch protection and “has open pull request” state, and simplifies several existing context-key bindings.
- Updates “Last turn” diff computation to use an
ObservablePromise-backed observable.
Comments suppressed due to low confidence (1)
src/vs/sessions/contrib/changes/browser/changesView.ts:640
lastTurnChangesObsusesObservablePromise(...).resolvedValue, which throws when the underlyingdiffBetweenWithStatspromise rejects (e.g. for a root commit where${headCommit}^is invalid). That exception will bubble throughcombinedEntriesObsand can break rendering instead of just showing an empty last-turn list. Consider usingObservablePromise(...).promiseResultand mapping errors to an empty array/undefined(optionally logging), or otherwise catching promise rejection so UI stays functional.
if (!repository || !headCommit) {
return constObservable(undefined);
}
return new ObservablePromise(repository.diffBetweenWithStats(`${headCommit}^`, headCommit)).resolvedValue;
lramos15
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.