Fix any usages in the markdown preview sources#300841
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Mar 11, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes remaining any typings in the Markdown preview webview sources to align with the ongoing codebase cleanup in #269213 and reduce fragility from overly-broad type assertions.
Changes:
- Type
acquireVsCodeApi()messaging plumbing usingWebviewApiinstead ofany. - Replace
anyevent handling in style-load error tracking with DOM-safe types and null checks. - Tighten state and DOM element typings in the preview script (state shape, active line marker, and click target traversal).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| extensions/markdown-language-features/preview-src/messaging.ts | Types the VS Code webview API parameter (WebviewApi<unknown>) to remove any from message posting. |
| extensions/markdown-language-features/preview-src/loading.ts | Replaces any in the style error handler with Event | string and safely reads dataset.source. |
| extensions/markdown-language-features/preview-src/index.ts | Types persisted state and tightens DOM click traversal typing to remove any. |
| extensions/markdown-language-features/preview-src/activeLineMarker.ts | Narrows the active element tracking from any to HTMLElement | undefined. |
You can also share your feedback on Copilot code review. Take the survey.
Yoyokrazy
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #269213