Move troubleshoot skill to files-based approach#300907
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the existing TS-defined internal “troubleshoot” chat skill from the internal customizations registry, presumably as part of a transition to a file-based skill definition approach within the chat prompt/skills system.
Changes:
- Deleted the
troubleshootSkillInternalSkillimplementation (previously embedded as a TS string constant). - Removed the
troubleshootSkillimport/export and cleared the internal skills list inChatInternalCustomizations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/promptSyntax/internalCustomizations/skills/troubleshootSkill.ts | Removes the TS-embedded troubleshoot skill definition. |
| src/vs/workbench/contrib/chat/common/promptSyntax/internalCustomizations/internalCustomizations.ts | Stops registering any built-in internal skills (including troubleshoot). |
You can also share your feedback on Copilot code review. Take the survey.
.../workbench/contrib/chat/common/promptSyntax/internalCustomizations/internalCustomizations.ts
Show resolved
Hide resolved
justschen
previously approved these changes
Mar 12, 2026
jruales
approved these changes
Mar 12, 2026
jruales
reviewed
Mar 12, 2026
| default: {}, | ||
| default: { | ||
| 'https://code.visualstudio.com': true, | ||
| 'https://github.com/microsoft/vscode/wiki/*': true, |
Contributor
There was a problem hiding this comment.
Were these specific URLs intentionally allow-listed for all users by default? Will people be ok with that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: microsoft/vscode-copilot-chat#4365