Skip to content

fix(git): correctly pluralise line_length input validation#301071

Merged
lszomoru merged 2 commits intomicrosoft:mainfrom
BerkeBat:fix-git-line-length-plural
Mar 20, 2026
Merged

fix(git): correctly pluralise line_length input validation#301071
lszomoru merged 2 commits intomicrosoft:mainfrom
BerkeBat:fix-git-line-length-plural

Conversation

@BerkeBat
Copy link
Contributor

@BerkeBat BerkeBat commented Mar 12, 2026

Closes:

image image

To test/reproduce the fix:

  1. Open a project that has an initialized git repository (so that the git commit message text box is available)
  2. Type 51 characters (default value, otherwise type 1 more than your git.inputValidationSubjectLength, or your git.inputValidationLength, if the former is un-set).
    a. Observe that the line_length warning says '1 character'
  3. Add one more character
    a. Observe that the line_length warning says '2 characters'

@BerkeBat BerkeBat changed the title Correctly pluralise line_length git input validation Correctly pluralise line_length git input validation Mar 12, 2026
@vs-code-engineering
Copy link
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@lszomoru

Matched files:

  • extensions/git/src/diagnostics.ts

@BerkeBat BerkeBat changed the title Correctly pluralise line_length git input validation fix(git): correctly pluralise line_length input validation Mar 13, 2026
@BerkeBat
Copy link
Contributor Author

bumping, quick and easy one 😎

@lszomoru lszomoru enabled auto-merge (squash) March 20, 2026 11:05
@lszomoru lszomoru merged commit 4743b94 into microsoft:main Mar 20, 2026
18 checks passed
@BerkeBat BerkeBat deleted the fix-git-line-length-plural branch March 21, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants