fix: allow specifying an icon for config enums (fixes #123786)#301136
Open
locactus wants to merge 2 commits intomicrosoft:mainfrom
Open
fix: allow specifying an icon for config enums (fixes #123786)#301136locactus wants to merge 2 commits intomicrosoft:mainfrom
locactus wants to merge 2 commits intomicrosoft:mainfrom
Conversation
The ensureNoDisposablesAreLeakedInTestSuite() call is still invoked for its side-effect but the return value is not needed in this test suite. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @rzhao271Matched files:
|
Contributor
|
@locactus please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #123786
Summary
This PR adds support for displaying icons alongside configuration enum values in the Settings UI dropdown. Extension authors can prefix
markdownEnumDescriptionswith a codicon reference (for example$(zap) Fast mode) and the icon will render in the custom select box dropdown.Changes
icon?: ThemeIcontoISelectOptionItem.<span>inSelectListRendererwhen an option includes an icon..option-iconinselectBoxCustom.css.$(icon-id)markers frommarkdownEnumDescriptionsinsettingsWidgets.tsand validate them against the codicon registry.settingsTree.tsso enum settings use the custom select box dropdown when icons are present.Validation
git diff --name-only origin/main...HEADcontains only the expected 7 changed files for this fix.package.jsonortsconfig*.jsonchanges.How to test
markdownEnumDescriptionswith a leading codicon, for example: