enhance image carousel functionality and UI improvements#301376
Merged
enhance image carousel functionality and UI improvements#301376
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves the image carousel experience by flattening the thumbnail UI into a horizontal strip, enhancing navigation behavior, and expanding chat image attachments to open a multi-section carousel spanning multiple chat responses. Also updates modal editor title handling to react to editor label changes.
Changes:
- Adjust image carousel CSS/UI to use a flat horizontal thumbnail strip with section separators and improved sizing/overflow.
- Update the image carousel editor to build thumbnails without section sub-containers, auto-scroll the active thumbnail into view, and update the editor title based on the active section.
- Enhance chat image attachment opening to aggregate images across responses into multiple carousel sections, and update modal editor header labels when the active editor label changes.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/imageCarousel/browser/media/imageCarousel.css | Updates layout/overflow for the carousel and changes thumbnails into a horizontal strip with hidden scrollbars and separators. |
| src/vs/workbench/contrib/imageCarousel/browser/imageCarouselEditorInput.ts | Adds mutable editor input name + label-change event firing to support dynamic editor titles. |
| src/vs/workbench/contrib/imageCarousel/browser/imageCarouselEditor.ts | Flattens thumbnail DOM construction, adds active-thumbnail strip scrolling, and updates editor title per section. |
| src/vs/workbench/contrib/chat/browser/attachments/chatAttachmentWidgets.ts | Aggregates images across multiple chat responses into carousel sections when opening from an image attachment. |
| src/vs/workbench/browser/parts/editor/modalEditorPart.ts | Updates modal header label when the active editor’s label changes by subscribing to onDidChangeLabel. |
src/vs/workbench/contrib/imageCarousel/browser/imageCarouselEditor.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/attachments/chatAttachmentWidgets.ts
Show resolved
Hide resolved
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
rebornix
commented
Mar 13, 2026
| disposables.add(Event.runAndSubscribe(modalEditorService.onDidActiveEditorChange, () => { | ||
| const labelChangeDisposable = disposables.add(new MutableDisposable()); | ||
| let trackedEditor: EditorInput | undefined; | ||
| const updateLabel = () => { |
Member
Author
There was a problem hiding this comment.
Updating this listener so when the editor updates its title, it can be reflected on the modal editor title.
DonJayamanne
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.