Git - second attempt to adopt the @vscode/fs-copyfile package#301443
Merged
Git - second attempt to adopt the @vscode/fs-copyfile package#301443
@vscode/fs-copyfile package#301443Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the built-in Git extension to use the @vscode/fs-copyfile package for copying “worktree include” files when creating a new worktree, and adjusts the build/packaging pipeline so the new runtime dependency is shipped correctly.
Changes:
- Switch worktree include-file copying to
@vscode/fs-copyfileand refactor the path selection logic. - Add
@vscode/fs-copyfileas a dependency and externalize it in the Git extension’s esbuild config. - Update the built-in extension packaging logic to include esbuild externals, and mark
gitas a native extension for platform-specific packaging.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| extensions/git/src/repository.ts | Uses @vscode/fs-copyfile and changes how ignored/include paths are computed and copied into new worktrees. |
| extensions/git/package.json | Adds @vscode/fs-copyfile dependency. |
| extensions/git/package-lock.json | Locks @vscode/fs-copyfile (and node-addon-api) into the extension’s dependency graph. |
| extensions/git/esbuild.mts | Marks @vscode/fs-copyfile as an esbuild external for runtime resolution. |
| build/lib/extensions.ts | Ensures externally-required runtime deps are included when packaging esbuild-built built-in extensions; marks git as native. |
Files not reviewed (1)
- extensions/git/package-lock.json: Language not supported
You can also share your feedback on Copilot code review. Take the survey.
bpasero
previously approved these changes
Mar 13, 2026
Member
|
@lszomoru conflicts |
deepak1556
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.