Update title bar UI feature work and bug fixes#301497
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the update-indicator UX in the workbench (title bar + status bar), including new title bar modes, improved tooltip rendering, and post-install “what’s new” content.
Changes:
- Adds a new
update.titleBarmode (always) and refines “detailed” visibility rules. - Refactors
UpdateTooltipinto an externally-rendered, state-driven tooltip with version copy affordances and a post-install markdown section. - Adds version-change detection + telemetry in the title bar contribution.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/update/common/updateUtils.ts | Adds isMajorMinorVersionChange helper for version-change detection. |
| src/vs/workbench/contrib/update/browser/updateTooltip.ts | Refactors tooltip rendering; adds copy-version UI and post-install markdown fetch/render. |
| src/vs/workbench/contrib/update/browser/updateTitleBarEntry.ts | Reworks title bar indicator behavior/modes, tooltip lifecycle, version-change detection, telemetry. |
| src/vs/workbench/contrib/update/browser/updateStatusBarEntry.ts | Updates status bar contribution to drive tooltip rendering via renderState. |
| src/vs/workbench/contrib/update/browser/update.ts | Initializes titleBarEnabled earlier from configuration. |
| src/vs/workbench/contrib/update/browser/media/updateTooltip.css | Adjusts tooltip sizing; adds copy-button and markdown styling. |
| src/vs/workbench/contrib/update/browser/media/updateTitleBarEntry.css | Tweaks title bar entry height and underline styling. |
| src/vs/platform/update/electron-main/abstractUpdateService.ts | Import ordering change only. |
| src/vs/platform/update/common/update.config.contribution.ts | Extends configuration enum with always + updated descriptions. |
Comments suppressed due to low confidence (2)
src/vs/workbench/contrib/update/browser/updateTooltip.ts:475
- The version copy button is only wired for mouse
click. For keyboard accessibility, handle Enter/Space (keydown) to trigger the same action, and ensure focus behavior doesn’t propagate/close the hover unexpectedly.
this._register(dom.addDisposableListener(copyButton, 'click', e => {
e.preventDefault();
e.stopPropagation();
if (copyValue.value) {
this.clipboardService.writeText(copyValue.value);
}
}));
src/vs/workbench/contrib/update/browser/updateTitleBarEntry.ts:287
- The hover
disposecallback only callsonUserDismissedTooltip()whenthis.contentis still connected. If the entry is removed (e.g. context key flips to false) while the hover is open,tooltipVisiblemay never be cleared. Consider always notifying dismissal from this dispose callback (and let the caller decide whether it was user-initiated) to avoid stale state.
dispose: () => {
if (!!this.content?.isConnected) {
this.onUserDismissedTooltip();
}
}
src/vs/workbench/contrib/update/browser/media/updateTooltip.css
Outdated
Show resolved
Hide resolved
bpasero
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensured new UI is hidden under the setting.
Added call-to-action UI when minor or major version change is detected post-install.
Polished UX based on feedback.
Added telemetry event for new update UX.
Fixes #301226
Fixes #300941