trim leading slash from terminal commands#301550
Merged
meganrogge merged 5 commits intomainfrom Mar 13, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts how terminal tool commands are presented in the chat UI to avoid showing transient escape artifacts while a run_in_terminal tool call is streaming, addressing the UX issue reported in #301294.
Changes:
- Added
normalizeTerminalCommandForDisplayhelper to clean up displayed command strings. - Applied normalization when rendering streamed tool invocation messages and when computing
commandLine.forDisplayfor terminal confirmations. - Added unit tests covering quote-unescape behavior for the new normalization helper.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/browser/runInTerminalHelpers.test.ts | Adds unit coverage for the new command-display normalization helper. |
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/runInTerminalTool.ts | Uses normalized command text for streaming status text and forDisplay/confirmation rendering. |
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/runInTerminalHelpers.ts | Introduces normalizeTerminalCommandForDisplay used to remove escape artifacts in UI. |
src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/runInTerminalHelpers.ts
Outdated
Show resolved
Hide resolved
...s/workbench/contrib/terminalContrib/chatAgentTools/test/browser/runInTerminalHelpers.test.ts
Show resolved
Hide resolved
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Yoyokrazy
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @Tyriar
fix #301294