Cancel active request when archiving a chat session#302162
Merged
Conversation
Co-authored-by: bpasero <900690+bpasero@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
bpasero
March 16, 2026 16:32
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures that archiving an agent chat session also cancels any active in-flight chat request, preventing background execution after a session is archived.
Changes:
- Inject
IChatServiceintoAgentSessionsService. - Hook
onDidChangeSessionArchivedStateto cancel the current request when a session becomes archived.
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsService.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsService.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
roblourens
approved these changes
Mar 16, 2026
Member
|
Nice |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #280422
Archiving a running agent session left the request executing in the background. Now, archiving a session automatically cancels its active request.
IChatServiceintoAgentSessionsServiceand callcancelCurrentRequestForSessionwhenonDidChangeSessionArchivedStatefires withisArchived() === true/clearslash command, delegation) get cancellation for free