fix bypass approvals skipping "copy changes" confirmation widget

[justschen]

fix #302182

• fix issue where if you have exisiting changes in worktree CLI, when you are in bypass approvals, nothing happens

[Copilot]

Pull request overview

Fixes an issue in the chat tool auto-approval flow where “Bypass Approvals” could skip required multi-option confirmation UI for Copilot CLI/background sessions, resulting in no “copy changes” confirmation being shown.

Changes:

• Update tool auto-confirm logic to not bypass confirmation for specific “cannot be auto-approved” tools when the session is non-local.
• Add tests covering the CLI vs local-session behavior for these non-auto-approvable tools.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/vs/workbench/contrib/chat/browser/tools/languageModelToolsService.ts	Adds a session-type gate so certain tools still require confirmation UI under Bypass Approvals for non-local sessions.
src/vs/workbench/contrib/chat/test/browser/tools/languageModelToolsService.test.ts	Adds coverage to ensure CLI sessions require confirmation while local sessions still auto-approve under Bypass Approvals.

Comments suppressed due to low confidence (1)

src/vs/workbench/contrib/chat/browser/tools/languageModelToolsService.ts:1177

• Same as above: this check keys off getChatSessionType(...) !== localChatSessionType, which applies to all non-local session types (not just CLI/background). If the special-casing is intended only for CLI sessions, it would be safer/clearer to gate on the explicit CLI session type; otherwise adjust the comment/naming to match the broader scope.

			if (isAutoApproveLevel(request?.modeInfo?.permissionLevel) || this._isSessionLiveAutoApproveLevel(chatSessionResource)) {
				if (!(toolIdsThatCannotBeAutoApproved.has(toolId) && getChatSessionType(chatSessionResource) !== localChatSessionType)) {
					return { type: ToolConfirmKind.ConfirmationNotNeeded, reason: 'auto-approve-all' };
				}

---

You can also share your feedback on Copilot code review. Take the survey.