plugins: clear enablement state on marketplace plugin uninstall#302573
Merged
connor4312 merged 3 commits intomainfrom Mar 17, 2026
Merged
plugins: clear enablement state on marketplace plugin uninstall#302573connor4312 merged 3 commits intomainfrom
connor4312 merged 3 commits intomainfrom
Conversation
- Adds IEnablementModel.remove(key) to delete enablement entries from both profile and workspace storage - Calls remove() when uninstalling a marketplace plugin so that a disabled plugin does not retain stale disabled state after uninstall Fixes #301295 (Commit message generated by Copilot)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes stale enablement state for marketplace-installed chat agent plugins by explicitly clearing persisted enablement entries when a marketplace plugin is uninstalled, preventing “disabled + uninstalled” UI state.
Changes:
- Add
IEnablementModel.remove(key)to delete enablement entries from both profile and workspace storage. - Call
enablementModel.remove(...)during marketplace plugin uninstall flow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/common/plugins/agentPluginServiceImpl.ts |
Clears persisted enablement state as part of marketplace plugin removal. |
src/vs/workbench/contrib/chat/common/enablement.ts |
Extends enablement API with remove() and implements deletion for both profile/workspace maps. |
You can also share your feedback on Copilot code review. Take the survey.
roblourens
previously approved these changes
Mar 17, 2026
Yoyokrazy
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plugins: clear enablement state on marketplace plugin uninstall
both profile and workspace storage
disabled plugin does not retain stale disabled state after uninstall
Fixes #301295
(Commit message generated by Copilot)