chat: populate githubRepo for GitUri marketplace references#302596
Merged
connor4312 merged 2 commits intomainfrom Mar 18, 2026
Merged
chat: populate githubRepo for GitUri marketplace references#302596connor4312 merged 2 commits intomainfrom
connor4312 merged 2 commits intomainfrom
Conversation
When a plugin marketplace reference is a full GitHub URL (e.g. https://github.com/anthropics/claude-code) parsed as a GitUri, the githubRepo property was not being set. This caused the AgentPluginEditor to render the marketplace link as plain text instead of a clickable link. - Add extractGitHubRepo helper that extracts owner/repo from GitHub URLs - Set githubRepo on GitUri references when the authority is github.com - Also handle SCP-style references (git@github.com:org/repo.git) Fixes #301288 (Commit message generated by Copilot)
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes GitHub marketplace links not rendering as clickable in the Agent Plugin editor when a marketplace reference is provided as a full GitHub URL parsed as a GitUri.
Changes:
- Populate
githubRepoforMarketplaceReferenceKind.GitUrireferences when the authority isgithub.com. - Add
extractGitHubRepo()helper to deriveowner/repofrom GitHub URL/SCP-style inputs. - Extend SCP-style parsing to also compute
githubRepo.
You can also share your feedback on Copilot code review. Take the survey.
src/vs/workbench/contrib/chat/common/plugins/marketplaceReference.ts
Outdated
Show resolved
Hide resolved
rwoll
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chat: populate githubRepo for GitUri marketplace references
When a plugin marketplace reference is a full GitHub URL (e.g.
https://github.com/anthropics/claude-code) parsed as a GitUri, the
githubRepo property was not being set. This caused the AgentPluginEditor
to render the marketplace link as plain text instead of a clickable link.
Fixes #301288
(Commit message generated by Copilot)