Skip to content

better progress rendering for thinking vs. normal progress#302615

Merged
justschen merged 2 commits intomainfrom
justin/cubchoo
Mar 18, 2026
Merged

better progress rendering for thinking vs. normal progress#302615
justschen merged 2 commits intomainfrom
justin/cubchoo

Conversation

@justschen
Copy link
Collaborator

fixes issue where it's hard to tell what is progress, and what is clickable.

Copilot AI review requested due to automatic review settings March 18, 2026 00:30
@justschen justschen enabled auto-merge (squash) March 18, 2026 00:30
@vs-code-engineering vs-code-engineering bot added this to the 1.113.0 milestone Mar 18, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to make chat “thinking” vs. “working/progress” states easier to distinguish in the chat UI so progress rows read less like clickable items.

Changes:

  • Updates the thinking header labeling to default to “Thinking”, with a switch to “Working” after tool calls begin.
  • Allows the generic “working” progress row to use the existing chat.agent.thinking.phrases configuration (append/replace) for its label.
  • Refines the configuration descriptions for chat.agent.thinking.phrases to cover progress indicators.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatThinkingContentPart.ts Adjusts default thinking header text and dynamically shifts header prefix when tool calls appear.
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatProgressContentPart.ts Uses chat.agent.thinking.phrases to pick a “Working” label for the working progress row.
src/vs/workbench/contrib/chat/browser/chat.contribution.ts Updates configuration descriptions for thinking/loading phrase customization to include progress indicators.

You can also share your feedback on Copilot code review. Take the survey.

@justschen justschen merged commit d1cb3f5 into main Mar 18, 2026
20 checks passed
@justschen justschen deleted the justin/cubchoo branch March 18, 2026 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants