better progress rendering for thinking vs. normal progress#302615
Merged
better progress rendering for thinking vs. normal progress#302615
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make chat “thinking” vs. “working/progress” states easier to distinguish in the chat UI so progress rows read less like clickable items.
Changes:
- Updates the thinking header labeling to default to “Thinking”, with a switch to “Working” after tool calls begin.
- Allows the generic “working” progress row to use the existing
chat.agent.thinking.phrasesconfiguration (append/replace) for its label. - Refines the configuration descriptions for
chat.agent.thinking.phrasesto cover progress indicators.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatThinkingContentPart.ts | Adjusts default thinking header text and dynamically shifts header prefix when tool calls appear. |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatProgressContentPart.ts | Uses chat.agent.thinking.phrases to pick a “Working” label for the working progress row. |
| src/vs/workbench/contrib/chat/browser/chat.contribution.ts | Updates configuration descriptions for thinking/loading phrase customization to include progress indicators. |
You can also share your feedback on Copilot code review. Take the survey.
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatThinkingContentPart.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatThinkingContentPart.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatProgressContentPart.ts
Outdated
Show resolved
Hide resolved
TylerLeonhardt
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes issue where it's hard to tell what is progress, and what is clickable.