Skip to content

fix: track disposables for serialized tool invocations in thinking part #302641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vikeychen wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

fix: track disposables for serialized tool invocations in thinking part #302641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatThinkingContentPart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1324,14 +1324,19 @@ ${this.hookCount > 0 ? `EXAMPLES WITH BLOCKED CONTENT (from hooks):

this.toolInvocations.push(toolInvocationOrMarkdown);

// Ensure a DisposableStore exists for all tool invocation kinds so that
// disposables registered via appendItem are tracked and cleaned up.
if (!this.toolDisposables.has(toolInvocationOrMarkdown.toolCallId)) {
this.toolDisposables.set(toolInvocationOrMarkdown.toolCallId, new DisposableStore());
}

// track state for live/still streaming tools, excluding serialized tools
if (toolInvocationOrMarkdown.kind === 'toolInvocation') {
let currentToolLabel = toolCallLabel;
let isComplete = false;
let isStreaming = IChatToolInvocation.isStreaming(toolInvocationOrMarkdown);

const toolStore = new DisposableStore();
this.toolDisposables.set(toolInvocationOrMarkdown.toolCallId, toolStore);
const toolStore = this.toolDisposables.get(toolInvocationOrMarkdown.toolCallId)!;

const updateTitle = (updatedMessage: string) => {
if (updatedMessage && updatedMessage !== currentToolLabel) {
Expand Down