Skip to content

editors - update comment on modal close#302757

Merged
bpasero merged 2 commits intomainfrom
ben/individual-landfowl
Mar 18, 2026
Merged

editors - update comment on modal close#302757
bpasero merged 2 commits intomainfrom
ben/individual-landfowl

Conversation

@bpasero
Copy link
Member

@bpasero bpasero commented Mar 18, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 18, 2026 10:51
@bpasero bpasero enabled auto-merge (squash) March 18, 2026 10:51
@bpasero bpasero self-assigned this Mar 18, 2026
@vs-code-engineering vs-code-engineering bot added this to the 1.113.0 milestone Mar 18, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the documentation for the modal editor part close behavior so callers understand how closing a modal interacts with dirty editors and confirmation prompts.

Changes:

  • Documented the mergeAllEditorsToMainPart option on IModalEditorPart.close(), describing how it affects dirty editor confirmation behavior.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@bpasero bpasero merged commit 3888a55 into main Mar 18, 2026
20 checks passed
@bpasero bpasero deleted the ben/individual-landfowl branch March 18, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants