feat - add rule to prevent static imports in critical startup path#302772
Merged
feat - add rule to prevent static imports in critical startup path#302772
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new local ESLint rule intended to protect the Electron main-process startup path by preventing synchronous loading of heavy node_modules via static imports, and wires the rule into the repo’s ESLint config for Electron main/node layers.
Changes:
- Add
local/code-no-static-node-module-importrule implementation to the local ESLint plugin. - Enable the rule (with a small allowlist) for Electron main + node-layer TypeScript files in
eslint.config.js.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
eslint.config.js |
Enables the new local rule for Electron main/node startup-critical paths and defines allowlisted file globs. |
.eslint-plugin-local/code-no-static-node-module-import.ts |
Implements the new rule that reports disallowed static imports and supports a per-file allowlist. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
ulugbekna
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.