[TerminalSandboxing]: Include workspace folders as default in the sandbox config#302834
Merged
dileepyavan merged 2 commits intomainfrom Mar 18, 2026
Merged
[TerminalSandboxing]: Include workspace folders as default in the sandbox config#302834dileepyavan merged 2 commits intomainfrom
dileepyavan merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the terminal sandbox config generation so that workspace folder paths are included in the default filesystem allowWrite list, and ensures the config is refreshed when workspace folders change (multi-root support).
Changes:
- Add
IWorkspaceContextServicedependency toTerminalSandboxServiceand refresh sandbox config on workspace folder changes. - Include current workspace folder paths in the generated sandbox filesystem
allowWritelist. - Extend unit tests with a workspace context service mock and a test covering config refresh on folder changes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/common/terminalSandboxService.ts | Adds workspace-folder-driven allowWrite defaults and triggers config regeneration on workspace folder changes. |
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/browser/terminalSandboxService.test.ts | Adds workspace context mocking and a test asserting config refresh behavior when workspace folders change. |
You can also share your feedback on Copilot code review. Take the survey.
src/vs/workbench/contrib/terminalContrib/chatAgentTools/common/terminalSandboxService.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/chatAgentTools/common/terminalSandboxService.ts
Show resolved
Hide resolved
...workbench/contrib/terminalContrib/chatAgentTools/test/browser/terminalSandboxService.test.ts
Show resolved
Hide resolved
jrieken
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #302904
This PR adds the multi root workspace folders as default to the sandbox config