Skip to content

chore: add telemetry for network process lifetime #302836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepak1556 merged 2 commits into from
Mar 18, 2026
Merged

chore: add telemetry for network process lifetime #302836

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c4da9a
chore: add telemetry for network process lifetime
deepak1556 Mar 18, 2026
40d65c4
chore: address review
deepak1556 Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 31 additions & 6 deletions src/vs/code/electron-main/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1582,13 +1582,38 @@ export class CodeApplication extends Disposable {

const customApp = app as AppWithNetworkProcessEvents;

this._register(Event.fromNodeEventEmitter<NetworkProcessLaunchedDetails>(customApp, 'network-process-launched', (_event, details) => details)(details => {
this.logService.info(`[network process] launched with pid ${details.pid}`);
}));
instantiationService.invokeFunction(accessor => {
const telemetryService = accessor.get(ITelemetryService);

this._register(Event.fromNodeEventEmitter<NetworkProcessGoneDetails>(customApp, 'network-process-gone', (_event, details) => details)(details => {
this.logService.info(`[network process] gone - pid: ${details.pid}, exitCode: ${details.exitCode}, crashed: ${details.crashed}, crashedPreIPC: ${details.crashedPreIPC}`);
}));
type NetworkProcessLaunchedClassification = {
owner: 'deepak1556';
comment: 'Tracks network process launch events.';
};

type NetworkProcessGoneClassification = {
exitCode: { classification: 'SystemMetaData'; purpose: 'PerformanceAndHealth'; isMeasurement: true; comment: 'The exit code of the network process.' };
crashed: { classification: 'SystemMetaData'; purpose: 'PerformanceAndHealth'; comment: 'Whether the network process crashed.' };
crashedPreIPC: { classification: 'SystemMetaData'; purpose: 'PerformanceAndHealth'; comment: 'Whether the network process crashed before IPC was established.' };
owner: 'deepak1556';
comment: 'Tracks network process gone events for reliability insights.';
};

this._register(Event.fromNodeEventEmitter<NetworkProcessLaunchedDetails>(customApp, 'network-process-launched', (_event, details) => details)(details => {
this.logService.info(`[network process] launched with pid ${details.pid}`);

telemetryService.publicLog2<{}, NetworkProcessLaunchedClassification>('networkProcess.launched', {});
}));

this._register(Event.fromNodeEventEmitter<NetworkProcessGoneDetails>(customApp, 'network-process-gone', (_event, details) => details)(details => {
this.logService.info(`[network process] gone - pid: ${details.pid}, exitCode: ${details.exitCode}, crashed: ${details.crashed}, crashedPreIPC: ${details.crashedPreIPC}`);

telemetryService.publicLog2<{ exitCode: number; crashed: boolean; crashedPreIPC: boolean }, NetworkProcessGoneClassification>('networkProcess.gone', {
exitCode: details.exitCode,
crashed: details.crashed,
crashedPreIPC: details.crashedPreIPC
});
}));
});
}
}

Expand Down
Loading