Refactor browser chat integration to use contributions#302936
Merged
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @jrualesMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the integrated browser’s chat-related functionality (element selection + console log attachment) out of the core BrowserEditor/actions file and into a dedicated editor “contribution”, to better separate concerns and centralize chat integration logic.
Changes:
- Removes the “Add Element to Chat” / “Add Console Logs to Chat” actions from
browserViewActions.tsand registers them from a new chat integration module. - Introduces a
BrowserEditorContributionpattern and a contribution registry onBrowserEditorto manage model-scoped lifecycles. - Extracts reusable element-formatting helpers into
platform/browserElements/common/browserElements.ts.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/browserView/electron-browser/browserViewActions.ts | Removes chat-related browser actions now handled by the new integration module. |
| src/vs/workbench/contrib/browserView/electron-browser/browserView.contribution.ts | Ensures the new chat integration module is loaded/registered. |
| src/vs/workbench/contrib/browserView/electron-browser/browserEditorChatIntegration.ts | Adds the contribution implementing element selection + chat attachments + console log attachments. |
| src/vs/workbench/contrib/browserView/electron-browser/browserEditor.ts | Adds contribution infrastructure and model lifecycle eventing; removes inlined chat integration logic. |
| src/vs/platform/browserElements/common/browserElements.ts | Adds shared helpers for building element context text (path/map/context formatting). |
You can also share your feedback on Copilot code review. Take the survey.
src/vs/workbench/contrib/browserView/electron-browser/browserEditorChatIntegration.ts
Show resolved
Hide resolved
jruales
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.