Skip to content

Enable reflowCursorLinefor Windows when conpty dll enabled#303000

Merged
anthonykim1 merged 2 commits intomainfrom
anthonykim1/reflowCursorXterm
Mar 18, 2026
Merged

Enable reflowCursorLinefor Windows when conpty dll enabled#303000
anthonykim1 merged 2 commits intomainfrom
anthonykim1/reflowCursorXterm

Conversation

@anthonykim1
Copy link
Contributor

Resolves: #274372

@anthonykim1 anthonykim1 added this to the 1.113.0 milestone Mar 18, 2026
@anthonykim1 anthonykim1 self-assigned this Mar 18, 2026
Copilot AI review requested due to automatic review settings March 18, 2026 21:42
@anthonykim1 anthonykim1 marked this pull request as ready for review March 18, 2026 21:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables xterm.js’ reflowCursorLine option for Windows terminals when using the VS Code-shipped conpty.dll, aiming to prevent prompt text loss during reflow (per #274372).

Changes:

  • Set xterm.raw.options.reflowCursorLine = true when the pty backend is conpty and terminal.integrated.windowsUseConptyDll is enabled.

@anthonykim1 anthonykim1 marked this pull request as draft March 18, 2026 21:48
@anthonykim1 anthonykim1 marked this pull request as ready for review March 18, 2026 21:58
@anthonykim1 anthonykim1 enabled auto-merge (squash) March 18, 2026 22:02
@anthonykim1 anthonykim1 merged commit b564a17 into main Mar 18, 2026
19 checks passed
@anthonykim1 anthonykim1 deleted the anthonykim1/reflowCursorXterm branch March 18, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use reflowCursorLine as ITerminalOptions for xterm

3 participants