Allow multiple code reviews per session version#303004
Merged
Conversation
…o a maximum of five; update tooltips and disable action accordingly
Contributor
There was a problem hiding this comment.
Pull request overview
Enables multiple (up to 5) code review runs for the same agent session “version” in the Agent Sessions window (vs/sessions), tracking per-version review count and updating UI/tooltips accordingly.
Changes:
- Add per-version
reviewCounttracking (and persistence) toCodeReviewServicestate, with a max of 5. - Allow rerunning a review for the same version when there are no remaining code review comments (including the “no comments produced” case).
- Update sessions toolbar/action tooltips and expand tests to cover the new behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/vs/sessions/contrib/codeReview/browser/codeReviewService.ts | Introduces reviewCount/didProduceComments in state, enforces max-per-version, and persists the new fields. |
| src/vs/sessions/contrib/codeReview/browser/codeReview.contributions.ts | Updates the toolbar action enablement/tooltip logic based on reviewCount and whether prior runs produced comments. |
| src/vs/sessions/contrib/codeReview/test/browser/codeReviewService.test.ts | Adds/updates tests for review reruns, review-count increments, and max limit behavior. |
| src/vs/sessions/contrib/agentFeedback/test/browser/sessionEditorComments.test.ts | Updates test helpers to construct the new ICodeReviewState.Result shape. |
You can also share your feedback on Copilot code review. Take the survey.
src/vs/sessions/contrib/codeReview/browser/codeReview.contributions.ts
Outdated
Show resolved
Hide resolved
src/vs/sessions/contrib/codeReview/browser/codeReview.contributions.ts
Outdated
Show resolved
Hide resolved
src/vs/sessions/contrib/codeReview/browser/codeReview.contributions.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
bhavyaus
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot Generated Description:Enable requesting up to five code reviews for the same session version. Update tooltips and disable actions accordingly based on the review count.closes #302669