Skip to content

add telemetry on thinking styles#303053

Merged
justschen merged 3 commits intomainfrom
justin/mienshao
Mar 19, 2026
Merged

add telemetry on thinking styles#303053
justschen merged 3 commits intomainfrom
justin/mienshao

Conversation

@justschen
Copy link
Collaborator

adds telemetry tracking for our setting

Copilot AI review requested due to automatic review settings March 19, 2026 03:40
@justschen justschen enabled auto-merge (squash) March 19, 2026 03:41
@vs-code-engineering vs-code-engineering bot added this to the 1.113.0 milestone Mar 19, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds telemetry in the Chat widget to record which “thinking style” rendering mode is in use when sending or rerunning a chat request, so usage can be analyzed across chat entry points/locations.

Changes:

  • Introduces a new chat.thinkingStyleUsage telemetry event (thinkingStyle, location, requestKind).
  • Logs the event on request submit and on rerun of the last request.
  • Adds a small helper to sanitize/normalize the configured thinking style before logging.
Comments suppressed due to low confidence (1)

src/vs/workbench/contrib/chat/browser/widget/chatWidget.ts:2438

  • Telemetry for chat.thinkingStyleUsage is logged immediately after sendRequest(...) returns a non-rejected ChatSendResult, but before awaiting the queued result (result.deferred) and confirming ChatSendResult.isSent(sent). If a request is queued and later not sent (or fails), this will still emit a usage event. Move this log to after the isSent check so the event only fires for actually-sent requests.
		this.logThinkingStyleUsage('submit');

		// visibility sync before firing events to hide the welcome view
		this.updateChatViewVisibility();
		this.input.acceptInput(options?.storeToHistory ?? isUserQuery);

You can also share your feedback on Copilot code review. Take the survey.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@justschen justschen merged commit cefcd7a into main Mar 19, 2026
19 checks passed
@justschen justschen deleted the justin/mienshao branch March 19, 2026 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants