Skip to content

Add inlineChat.askInChat setting to toggle Ask in Chat vs Inline Chat#303161

Merged
jrieken merged 2 commits intomainfrom
joh/inline-chat-ask-in-chat-setting
Mar 19, 2026
Merged

Add inlineChat.askInChat setting to toggle Ask in Chat vs Inline Chat#303161
jrieken merged 2 commits intomainfrom
joh/inline-chat-ask-in-chat-setting

Conversation

@jrieken
Copy link
Member

@jrieken jrieken commented Mar 19, 2026

Adds a new inlineChat.askInChat boolean setting (default: true) that controls whether Cmd+I / Ctrl+I in a file belonging to a chat editing session opens Ask in Chat or regular Inline Chat.

When enabled (default): behavior is unchanged - the keybinding triggers Ask in Chat for chat-owned files.
When disabled: the keybinding always opens regular Inline Chat, even for chat-owned files.

Fixes #300439

@jrieken jrieken self-assigned this Mar 19, 2026
Copilot AI review requested due to automatic review settings March 19, 2026 11:43
@jrieken jrieken enabled auto-merge (squash) March 19, 2026 11:43
@vs-code-engineering vs-code-engineering bot added this to the 1.113.0 milestone Mar 19, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new inlineChat.askInChat configuration toggle to control whether chat-owned files (files belonging to a chat editing session) route Cmd/Ctrl+I into “Ask in Chat” vs opening regular Inline Chat.

Changes:

  • Register new boolean setting inlineChat.askInChat (default true) and expose it as a context expression (CTX_ASK_IN_CHAT_ENABLED).
  • Update Inline Chat actions/keybindings/menus so Cmd/Ctrl+I and the inline input’s Enter behavior switch between “Ask in Chat” and regular Inline Chat based on the setting.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/vs/workbench/contrib/inlineChat/common/inlineChat.ts Adds the new setting + context expression for inlineChat.askInChat.
src/vs/workbench/contrib/inlineChat/browser/inlineChatActions.ts Applies the setting to Cmd/Ctrl+I routing and inline input send/queue/menu visibility.

You can also share your feedback on Copilot code review. Take the survey.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@jrieken jrieken merged commit 56f4a89 into main Mar 19, 2026
19 checks passed
@jrieken jrieken deleted the joh/inline-chat-ask-in-chat-setting branch March 19, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inline chat and chat session as released in version 1.110

3 participants