sessions - fix title bar issue on macOS#303224
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Agent Sessions titlebar implementation to address a macOS-specific Electron issue where the Sessions window may not appear in the system “Windows” menu due to the initial document.title value.
Changes:
- Inject
IProductServiceinto Sessions titlebar parts so the product’s native window title can be applied consistently. - Add a macOS title “toggle” workaround in the Sessions browser titlebar to force macOS/Electron to recognize the window in the “Windows” menu.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/sessions/electron-browser/parts/titlebarPart.ts | Threads IProductService through native titlebar part constructors and super calls. |
| src/vs/sessions/browser/parts/titlebarPart.ts | Injects IProductService and applies a macOS document.title workaround during titlebar creation. |
rzhao271
approved these changes
Mar 19, 2026
chrmarti
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.