sessions - tweaks to grouping by repo (fix #302453)#303250
Merged
Conversation
Yoyokrazy
approved these changes
Mar 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts how agent sessions are grouped by repository, specifically ensuring sessions without repository metadata (“Other”) are placed consistently after named repositories and before Archived sessions, and updates the Sessions view UI to reflect the new grouping control placement.
Changes:
- Update repository-grouping logic to collect “Other” sessions separately and append that group after named repositories.
- Remove now-unneeded
ILogServiceplumbing fromAgentSessionsDataSourceconstruction. - Add a regression test asserting ordering of repo groups vs “Other” vs “Archived”, and tweak the Sessions view title menu/grouping action placement.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/browser/agentSessions/agentSessionsDataSource.test.ts | Adds a regression test ensuring “Other” is ordered after named repos and before Archived. |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsViewer.ts | Refactors repo grouping to accumulate “Other” sessions separately and drops logging dependency. |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsControl.ts | Removes ILogService injection and stops passing it into AgentSessionsDataSource. |
| src/vs/sessions/contrib/sessions/browser/sessionsViewPane.ts | Updates the view title submenu icon and moves “Group by Repository” into the filter submenu as a toggled item. |
bryanchen-d
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.