Enhance URL glob matching to enforce subdomain wildcard matching on dot boundaries#303263
Merged
TylerLeonhardt merged 1 commit intomainfrom Mar 19, 2026
Merged
Enhance URL glob matching to enforce subdomain wildcard matching on dot boundaries#303263TylerLeonhardt merged 1 commit intomainfrom
TylerLeonhardt merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Tightens *. subdomain wildcard handling in the URL glob matcher so that *.example.com only matches on a dot boundary (or the bare apex domain), preventing unintended matches like notexample.com.
Changes:
- Update
*.matching logic to only “exit” the subdomain wildcard at the start of the authority or immediately after a.in the URL. - Add regression tests ensuring
*.domain.comdoes not match lookalike domains lacking a dot boundary (e.g.evil-microsoft.com,notexample.com). - Add coverage for the same dot-boundary rule when the glob omits the scheme.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/vs/platform/url/common/urlGlob.ts |
Restricts *. wildcard transitions to dot boundaries / start-of-authority to avoid overbroad domain matches. |
src/vs/platform/url/test/common/urlGlob.test.ts |
Adds targeted test cases validating the new dot-boundary behavior (with and without scheme). |
You can also share your feedback on Copilot code review. Take the survey.
dmitrivMS
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.