Skip to content

Browser: Upgrade Playwright to 1.59.0-alpha-2026-03-19#303285

Draft
jruales wants to merge 2 commits intomainfrom
jruales/upgrade-playwright-3-19
Draft

Browser: Upgrade Playwright to 1.59.0-alpha-2026-03-19#303285
jruales wants to merge 2 commits intomainfrom
jruales/upgrade-playwright-3-19

Conversation

@jruales
Copy link
Contributor

@jruales jruales commented Mar 19, 2026

No rush to check this in. Just here as reference of what the upgrade would involve

Copilot AI review requested due to automatic review settings March 19, 2026 18:53
@jruales jruales changed the title Upgrade Playwright to 03/19 Browser: Upgrade Playwright to 03/19 Mar 19, 2026
@jruales jruales requested review from kycutler and removed request for Copilot March 19, 2026 18:53
@jruales jruales changed the title Browser: Upgrade Playwright to 03/19 Browser: Upgrade Playwright to 1.59.0-alpha-2026-03-19 Mar 19, 2026
Copilot AI review requested due to automatic review settings March 19, 2026 18:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the integrated-browser Playwright dependency and aligns VS Code’s Playwright tab summarization logic with the newer Playwright snapshot API, improving compatibility with upstream Playwright changes.

Changes:

  • Bump playwright-core from 1.59.0-alpha-2026-02-20 to 1.59.0-alpha-2026-03-19.
  • Switch from the hidden Page._snapshotForAI(...) API to Page.snapshotForAI(...) with mode support.
  • Remove the local TypeScript module augmentation that declared _snapshotForAI on playwright-core’s Page.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/vs/platform/browserView/node/playwrightTab.ts Updates snapshot acquisition to use the new snapshotForAI API and adjusts summary assembly accordingly.
package.json Pins playwright-core to the 2026-03-19 alpha build.
package-lock.json Updates the lockfile to match the bumped playwright-core version, tarball URL, and integrity hash.

Comment on lines +161 to 164
const snapshotFromPage = await this.safeRunAgainstPage((page) => page.snapshotForAI({ track: 'response', mode: full ? 'full' : 'incremental' })).catch(() => {
this._needsFullSnapshot = true;
return undefined;
});
@jruales jruales marked this pull request as draft March 19, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants