Sessions - more changes view cleanup#303303
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs cleanup and lifecycle/disposal improvements for the Sessions “Changes” view, including renaming the related workbench contribution/controller and tightening up view ownership of disposables.
Changes:
- Rename the changes view workbench contribution to
ChangesViewControllerand update its contribution registration. - Ensure
ChangesViewPaneproperly disposes itsChangesViewModel. - Refactor how the actions toolbar’s scoped instantiation service is created for the changes view.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/sessions/contrib/changes/browser/changesViewController.ts | Renames the workbench contribution/controller class and its contribution ID. |
| src/vs/sessions/contrib/changes/browser/changesView.ts | Improves disposal of viewModel; refactors scoped instantiation service creation for the toolbar. |
| src/vs/sessions/contrib/changes/browser/changesView.contribution.ts | Updates imports/registration to use ChangesViewController. |
dmitrivMS
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.