Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Simple Browser built-in extension so that, on desktop, it effectively routes users to the Integrated Browser instead of the legacy Simple Browser webview.
Changes:
- Removed the
simpleBrowser.useIntegratedBrowsersetting and its localization string. - Updated the runtime selection logic to use the Integrated Browser whenever the Integrated Browser command is available.
- Hid
simpleBrowser.showfrom the Command Palette on desktop by contributing it only whenisWeb.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
extensions/simple-browser/src/extension.ts |
Removes the config gate so desktop always uses Integrated Browser when available. |
extensions/simple-browser/package.nls.json |
Removes the localized description for the deleted setting. |
extensions/simple-browser/package.json |
Removes the setting contribution and restricts Command Palette visibility of simpleBrowser.show to web. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jruales
reviewed
Mar 19, 2026
| const openApiCommand = 'simpleBrowser.api.open'; | ||
| const showCommand = 'simpleBrowser.show'; | ||
| const integratedBrowserCommand = 'workbench.action.browser.open'; | ||
| const useIntegratedBrowserSetting = 'simpleBrowser.useIntegratedBrowser'; |
Contributor
There was a problem hiding this comment.
Let's also update the docs site(s) to remove all mentions of this setting
jruales
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.