Browser: feature contributions for storage / devtools#303320
Merged
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @jrualesMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the integrated Browser View workbench contribution to move devtools and data storage-related behavior into dedicated feature modules, reducing cross-file coupling and keeping browserViewActions.ts focused on core navigation/find actions.
Changes:
- Move devtools context tracking + “Toggle Developer Tools” action registration into a new
browserDevToolsFeature.ts. - Move storage-scope context tracking, storage-clearing actions, and the
workbench.browser.dataStoragesetting registration into a newbrowserDataStorageFeatures.ts. - Reduce exported surface area by making several context keys file-local and removing devtools/storage-scope context key exports from
browserEditor.ts.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/browserView/electron-browser/features/browserTabManagementFeatures.ts | Makes the “browser editor open” context key internal to the feature module. |
| src/vs/workbench/contrib/browserView/electron-browser/features/browserEditorZoomFeature.ts | Makes zoom capability context keys internal to the zoom feature module. |
| src/vs/workbench/contrib/browserView/electron-browser/features/browserEditorChatFeatures.ts | Makes element-selection context key internal to the chat feature module. |
| src/vs/workbench/contrib/browserView/electron-browser/features/browserDevToolsFeature.ts | New feature module that tracks devtools state and registers the devtools toggle action. |
| src/vs/workbench/contrib/browserView/electron-browser/features/browserDataStorageFeatures.ts | New feature module that tracks storage scope, registers clear-storage actions, and registers the data storage setting. |
| src/vs/workbench/contrib/browserView/electron-browser/browserViewActions.ts | Removes devtools/storage actions from the central actions file (now handled by feature modules). |
| src/vs/workbench/contrib/browserView/electron-browser/browserView.contribution.ts | Imports the new feature modules so they are registered as part of the browser view contribution. |
| src/vs/workbench/contrib/browserView/electron-browser/browserEditor.ts | Removes devtools/storage-scope context key wiring from the editor itself (now handled via contributions). |
src/vs/workbench/contrib/browserView/electron-browser/features/browserDataStorageFeatures.ts
Outdated
Show resolved
Hide resolved
…/browserDataStorageFeatures.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jruales
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.