Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the proposed “browser” extension API plumbing (workbench ⇄ ext host) by reducing payload size and avoiding redundant RPC notifications when tracking browser editor tabs.
Changes:
- Change the “active browser tab changed” callback to send only the tab id (instead of a full DTO) and only when the id actually changes.
- Change the “browser tab state changed” callback to send only the DTO (dropping the redundant id parameter).
- Update the ext host protocol definitions accordingly.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/vs/workbench/api/common/extHostBrowsers.ts | Adapts ext host-side tab tracking callbacks to new signatures (but needs signature alignment for undefined). |
| src/vs/workbench/api/common/extHost.protocol.ts | Updates the RPC contract for active-tab and state-change notifications. |
| src/vs/workbench/api/browser/mainThreadBrowsers.ts | Sends fewer active-tab change RPCs and simplifies tab state change notifications. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
hediet
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.