Multi-select adoption for compressed tree#303511
Merged
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @joaomorenoMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for grouped selection (via IIdentityProvider.getGroupId) when using compressed tree nodes, ensuring multi-select behavior continues to work when identity providers are wrapped/mapped through tree layers.
Changes:
- Propagate
getGroupIdthrough compressed tree identity-provider wrappers (wrapIdentityProvider,mapOptions). - Propagate
getGroupIdthroughAsyncDataTree’sdiffIdentityProviderwrapper. - Add regression tests around
updateOptions()preserving wrapped identity/accessibility providers.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/vs/base/test/browser/ui/tree/objectTree.test.ts | Adds tests and helpers to validate wrapped providers survive updateOptions() and still drive selection/type-nav behavior. |
| src/vs/base/browser/ui/tree/compressedObjectTreeModel.ts | Extends compressed-tree identity provider wrapping to forward getGroupId to underlying elements. |
| src/vs/base/browser/ui/tree/asyncDataTree.ts | Extends diffIdentityProvider wrapper to forward getGroupId for nodes. |
chrmarti
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot Generated Description:Implement multi-select functionality in the compressed tree structure, allowing users to select multiple items simultaneously. This includes updates to the identity provider to support group IDs and modifications to the tree's options to preserve selection behavior.