Fix listener leak in chat code block editor pool disposal ordering#303548
Closed
Fix listener leak in chat code block editor pool disposal ordering#303548
Conversation
When updateViewModel() is called, templates need to release their pool items back before the pools are cleared. Previously, clear() was called first, disposing only the available pool items. Then the event triggered template clearing, which released items back into the pool arrays — but those items were never disposed because clear() had already run. Fix by reordering: fire the event first so templates release their pool items, then clear the pools to properly dispose all released items. Also guard IDisposableReference.dispose() against double-release which could cause pool corruption. Co-authored-by: jrieken <1794099+jrieken@users.noreply.github.com> Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/d4642fd3-0686-47a6-a0b0-776d87791453
Copilot
AI
changed the title
[WIP] Fix potential listener leak issue #1ab
Fix listener leak in chat code block editor pool disposal ordering
Mar 20, 2026
Member
|
@connor4312 I believe you originally wrote this code |
Member
|
ah, apparently fixed by #303620 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Listener leak (6500+) on global
LanguageFeatureRegistryemitters caused by undisposedCodeEditorWidgetinstances in chatEditorPool. Each pooledCodeBlockPartholds aCodeEditorWidgetwhoseEditorModeContextregisters ~16 listeners on global language feature registries.Root cause: In
updateViewModel(),_editorPool.clear()ran before_onDidUpdateViewModel.fire(). The event triggersclearRenderedParts()on templates, which releases pool items back into the pool array viaResourcePool.release(). Sinceclear()already ran, these items sat in the pool indefinitely — never disposed, listeners never removed.Changes:
updateViewModel()— fire the event first so templates release pool items, then clear pools to dispose themIDisposableReference.dispose()against double-release — prevents pool corruption where the sameCodeBlockPartappears twice in the pool arrayWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
disallowed.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --crashpad-handler-pid=9588 --enable-crash-reporter=ca5bbdb2-cd8e-49c8-8d3e-cb2bbfd0b78c,no_channel --user-data-dir=/tmp/vscode-tests-1774025468427 --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,17767181790482287149,5394987817279806358,262144 --enable-features=PdfUseShowSaveFilePicker --disable-features=LocalNetworkAccessChecks,ScreenAIOCREnabled,SpareRendererForSitePerProcess,TraceSiteInstanceGetProcessCreation --variations-seed-version --trace-process-track-uuid=3190708989122997041 nfig/composer/vendor/bin/sh de/extensions/desh(dns block).build/electron/code-oss .build/electron/code-oss test/unit/electron/index.js --crash-reporter-directory=/home/REDACTED/work/vscode/vscode/.build/crashes ./src/vs/workbench/contrib/chat/test/browser/widget/chatContentParts/ -c xtensions/markdown-math/tsconfig.json --pretty false --sourceMap --inlineSources /tsconfig.json in/sh es(dns block)example.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --crashpad-handler-pid=9588 --enable-crash-reporter=ca5bbdb2-cd8e-49c8-8d3e-cb2bbfd0b78c,no_channel --user-data-dir=/tmp/vscode-tests-1774025468427 --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,17767181790482287149,5394987817279806358,262144 --enable-features=PdfUseShowSaveFilePicker --disable-features=LocalNetworkAccessChecks,ScreenAIOCREnabled,SpareRendererForSitePerProcess,TraceSiteInstanceGetProcessCreation --variations-seed-version --trace-process-track-uuid=3190708989122997041 nfig/composer/vendor/bin/sh de/extensions/desh(dns block).build/electron/code-oss .build/electron/code-oss test/unit/electron/index.js --crash-reporter-directory=/home/REDACTED/work/vscode/vscode/.build/crashes ./src/vs/workbench/contrib/chat/test/browser/widget/chatContentParts/ -c xtensions/markdown-math/tsconfig.json --pretty false --sourceMap --inlineSources /tsconfig.json in/sh es(dns block)mobile.events.data.microsoft.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --crashpad-handler-pid=9588 --enable-crash-reporter=ca5bbdb2-cd8e-49c8-8d3e-cb2bbfd0b78c,no_channel --user-data-dir=/tmp/vscode-tests-1774025468427 --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,17767181790482287149,5394987817279806358,262144 --enable-features=PdfUseShowSaveFilePicker --disable-features=LocalNetworkAccessChecks,ScreenAIOCREnabled,SpareRendererForSitePerProcess,TraceSiteInstanceGetProcessCreation --variations-seed-version --trace-process-track-uuid=3190708989122997041 nfig/composer/vendor/bin/sh de/extensions/desh(dns block).build/electron/code-oss .build/electron/code-oss test/unit/electron/index.js --crash-reporter-directory=/home/REDACTED/work/vscode/vscode/.build/crashes ./src/vs/workbench/contrib/chat/test/browser/widget/chatContentParts/ -c xtensions/markdown-math/tsconfig.json --pretty false --sourceMap --inlineSources /tsconfig.json in/sh es(dns block)redirector.gvt1.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --crashpad-handler-pid=7887 --enable-crash-reporter=ca5bbdb2-cd8e-49c8-8d3e-cb2bbfd0b78c,no_channel --user-data-dir=/tmp/vscode-tests-1774025278152 --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,7940741220924357645,3441140531715102107,262144 --enable-features=PdfUseShowSaveFilePicker --disable-features=LocalNetworkAccessChecks,ScreenAIOCREnabled,SpareRendererForSitePerProcess,TraceSiteInstanceGetProcessCreation --variations-seed-version --trace-process-track-uuid=3190708989122997041 -tmpfiles nce|instantiateVbash src/vs/workbench./scripts/test.sh(dns block).build/electron/code-oss .build/electron/code-oss test/unit/electron/index.js --crash-reporter-directory=/home/REDACTED/work/vscode/vscode/.build/crashes ./src/vs/workbench/contrib/chat/test/browser/widget/chatContentParts/ d rWidget\|new CodACCEPT src/vs/workbench/contrib/chat/browser/widget/chatContentParts/toolInvocationParts/ /home/REDACTED/.config/composer/vendor/bin/bash(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --crashpad-handler-pid=9588 --enable-crash-reporter=ca5bbdb2-cd8e-49c8-8d3e-cb2bbfd0b78c,no_channel --user-data-dir=/tmp/vscode-tests-1774025468427 --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,17767181790482287149,5394987817279806358,262144 --enable-features=PdfUseShowSaveFilePicker --disable-features=LocalNetworkAccessChecks,ScreenAIOCREnabled,SpareRendererForSitePerProcess,TraceSiteInstanceGetProcessCreation --variations-seed-version --trace-process-track-uuid=3190708989122997041 nfig/composer/vendor/bin/sh de/extensions/desh(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.