Add eslint rule for telemetry props that override common props#303592
Merged
roblourens merged 1 commit intomainfrom Mar 20, 2026
Merged
Add eslint rule for telemetry props that override common props#303592roblourens merged 1 commit intomainfrom
roblourens merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new repo-local ESLint rule to prevent telemetry event payloads from defining keys that collide with VS Code’s “common properties” (which are automatically injected into every telemetry event by the telemetry pipeline).
Changes:
- Enable a new local ESLint rule for
src/**/*.tsto warn on common telemetry property names in event data. - Add
.eslint-plugin-local/code-no-telemetry-common-property.ts, which inspectspublicLog*calls and flags reserved property keys.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
eslint.config.js |
Enables local/code-no-telemetry-common-property (warn) for src/**/*.ts. |
.eslint-plugin-local/code-no-telemetry-common-property.ts |
Implements the ESLint rule that detects reserved/common telemetry properties in inline event payload objects. |
Yoyokrazy
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.