Skip to content

agentHost: fixup build for server#303597

Merged
connor4312 merged 3 commits intomainfrom
connor4312/agent-host-server-fixups
Mar 20, 2026
Merged

agentHost: fixup build for server#303597
connor4312 merged 3 commits intomainfrom
connor4312/agent-host-server-fixups

Conversation

@connor4312
Copy link
Member

No description provided.

- Pass agent-host through like serve-web to the cli
- Fix agentHost bundle not being included in server build
- Fix CLI targeting the server binary incorrectly
Copilot AI review requested due to automatic review settings March 20, 2026 19:34
@connor4312 connor4312 enabled auto-merge (squash) March 20, 2026 19:35
@vs-code-engineering
Copy link
Contributor

vs-code-engineering bot commented Mar 20, 2026

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@lszomoru

Matched files:

  • build/azure-pipelines/win32/product-build-win32-cli.yml

@bpasero

Matched files:

  • src/vs/platform/environment/common/argv.ts
  • src/vs/platform/environment/node/argv.ts

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates VS Code’s native CLI argument surface and build/pipeline configuration so the agent-host server entrypoint can be built for server targets and invoked as a native subcommand, while also adjusting the CLI’s server cache handling.

Changes:

  • Add agent-host as a native CLI subcommand (types + option descriptions).
  • Include vs/platform/agentHost/node/agentHostMain in the server build entrypoints.
  • Adjust CLI server caching/extraction behavior and tweak the Win32 CLI pipeline artifact contents.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/vs/platform/environment/node/argv.ts Registers agent-host as a native CLI command and defines its options.
src/vs/platform/environment/common/argv.ts Extends NativeParsedArgs typing to include the agent-host subcommand.
cli/src/commands/agent_host.rs Updates server cache keying to include quality and adjusts extraction path; adds a startup print.
build/next/index.ts Adds agentHostMain to serverEntryPoints so it’s produced in server builds.
build/azure-pipelines/win32/product-build-win32-cli.yml Removes CodeSignSummary markdown files prior to archiving the signed CLI.

@connor4312 connor4312 merged commit b7462b4 into main Mar 20, 2026
19 checks passed
@connor4312 connor4312 deleted the connor4312/agent-host-server-fixups branch March 20, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants