node_modules is stale -> ignore node-version changes#303609
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces false-positive “node_modules is stale” signals by allowing tooling to ignore Node.js version mismatches when computing the postinstall install-state hash.
Changes:
- Add an
ignoreNodeVersionoption tocomputeStateto optionally omit the running Node.js version from the computed state. - Extend
installStateHash.ts’s CLI output mode to support a new--ignore-node-versionflag and normalize the reported saved/current state accordingly. - Update the
vscode-extras“npm up-to-date” feature to callinstallStateHash.tswith--ignore-node-version.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| build/npm/installStateHash.ts | Adds an opt-in path to ignore Node version in computed/printed state and introduces a CLI flag to drive it for external tooling. |
| .vscode/extensions/vscode-extras/src/npmUpToDateFeature.ts | Passes the new CLI flag so the status indicator won’t trigger solely due to Node version changes. |
benvillalobos
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.