Remove unused IChatSessionDto.id field#303619
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Mar 20, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the unused id field from the chat session content DTO passed over the ext host ↔ main thread protocol, simplifying the contract and updating tests accordingly.
Changes:
- Remove the
idproperty from the chat session DTO returned by$provideChatSessionContent. - Update the ext host protocol type and ext host implementation to use the new DTO shape.
- Update main thread chat sessions tests to construct session content without
id.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/api/test/browser/mainThreadChatSessions.test.ts | Updates test DTO construction/typing to no longer include id. |
| src/vs/workbench/api/common/extHostChatSessions.ts | Stops generating/returning a synthetic session DTO id; updates return type accordingly. |
| src/vs/workbench/api/common/extHost.protocol.ts | Removes id from the session DTO shape and updates the RPC signature to return the new type. |
roblourens
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.