Skip to content

Try to clean up inProgress handling for chat sessions#303625

Merged
mjbvz merged 1 commit intomicrosoft:mainfrom
mjbvz:dev/mjbvz/possible-parakeet
Mar 20, 2026
Merged

Try to clean up inProgress handling for chat sessions#303625
mjbvz merged 1 commit intomicrosoft:mainfrom
mjbvz:dev/mjbvz/possible-parakeet

Conversation

@mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Mar 20, 2026

This api is very strange. Reducing where it's exposed because it really should not exist

This api is very strange. Reducing where it's exposed because it really should not exist
Copilot AI review requested due to automatic review settings March 20, 2026 22:03
@mjbvz mjbvz enabled auto-merge March 20, 2026 22:03
@vs-code-engineering vs-code-engineering bot added this to the 1.113.0 milestone Mar 20, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors “in progress” tracking for chat/agent sessions by removing the externally-callable reporting API and switching consumers to work with chatSessionType identifiers instead of precomputed display names, with the goal of reducing exposure of a brittle API surface.

Changes:

  • Removed reportInProgress(...) from IChatSessionsService and adjusted getInProgress() to return { chatSessionType, count }.
  • Updated the chat status dashboard to resolve a display name from chatSessionType (with special-cases for built-in agent providers).
  • Adjusted mocks and internal tracking maps to key by chatSessionType rather than display name.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/vs/workbench/contrib/chat/test/common/mockChatSessionsService.ts Updates mock getInProgress() shape to return chatSessionType keys.
src/vs/workbench/contrib/chat/common/chatSessionsService.ts Removes reportInProgress from the service interface and deprecates getInProgress().
src/vs/workbench/contrib/chat/browser/chatStatus/chatStatusDashboard.ts Updates UI rendering to map chatSessionType → display label before showing “in progress” rows.
src/vs/workbench/contrib/chat/browser/chatSessions/chatSessions.contribution.ts Internal refactor of in-progress bookkeeping to store counts by chatSessionType and update counts on item deltas.

@mjbvz mjbvz merged commit 5fc1bf6 into microsoft:main Mar 20, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants