Try to clean up inProgress handling for chat sessions#303625
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Mar 20, 2026
Merged
Try to clean up inProgress handling for chat sessions#303625mjbvz merged 1 commit intomicrosoft:mainfrom
mjbvz merged 1 commit intomicrosoft:mainfrom
Conversation
This api is very strange. Reducing where it's exposed because it really should not exist
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors “in progress” tracking for chat/agent sessions by removing the externally-callable reporting API and switching consumers to work with chatSessionType identifiers instead of precomputed display names, with the goal of reducing exposure of a brittle API surface.
Changes:
- Removed
reportInProgress(...)fromIChatSessionsServiceand adjustedgetInProgress()to return{ chatSessionType, count }. - Updated the chat status dashboard to resolve a display name from
chatSessionType(with special-cases for built-in agent providers). - Adjusted mocks and internal tracking maps to key by
chatSessionTyperather than display name.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/common/mockChatSessionsService.ts | Updates mock getInProgress() shape to return chatSessionType keys. |
| src/vs/workbench/contrib/chat/common/chatSessionsService.ts | Removes reportInProgress from the service interface and deprecates getInProgress(). |
| src/vs/workbench/contrib/chat/browser/chatStatus/chatStatusDashboard.ts | Updates UI rendering to map chatSessionType → display label before showing “in progress” rows. |
| src/vs/workbench/contrib/chat/browser/chatSessions/chatSessions.contribution.ts | Internal refactor of in-progress bookkeeping to store counts by chatSessionType and update counts on item deltas. |
src/vs/workbench/contrib/chat/browser/chatSessions/chatSessions.contribution.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/chatSessions/chatSessions.contribution.ts
Show resolved
Hide resolved
pwang347
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This api is very strange. Reducing where it's exposed because it really should not exist