Avoid per-call allocation in isFilePatternMatch for ignoreCase option#303681
Merged
roblourens merged 2 commits intoroblou/artistic-spiderfrom Mar 21, 2026
Merged
Avoid per-call allocation in isFilePatternMatch for ignoreCase option#303681roblourens merged 2 commits intoroblou/artistic-spiderfrom
roblourens merged 2 commits intoroblou/artistic-spiderfrom
Conversation
…d per-call allocations Co-authored-by: roblourens <323878+roblourens@users.noreply.github.com> Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/a131b260-e6c0-47f6-aa2a-95ac0f24fe10
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on caseInsensitive setting for search API in agent tools
Avoid per-call allocation in isFilePatternMatch for ignoreCase option
Mar 21, 2026
roblourens
approved these changes
Mar 21, 2026
roblourens
added a commit
that referenced
this pull request
Mar 21, 2026
…03679) * Enable setting caseInsensitive through search API for agent tools Fix #303673 * Avoid per-call allocation in isFilePatternMatch for ignoreCase option (#303681) * Initial plan * Extract filePatternIgnoreCaseOptions as module-level constant to avoid per-call allocations Co-authored-by: roblourens <323878+roblourens@users.noreply.github.com> Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/a131b260-e6c0-47f6-aa2a-95ac0f24fe10 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: roblourens <323878+roblourens@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: roblourens <323878+roblourens@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isFilePatternMatchwas allocating{ ignoreCase: true }on every invocation whenignoreCasewas set. Since this function runs in tight file-walking loops, the repeated allocations add unnecessary GC pressure.filePatternIgnoreCaseOptions = { ignoreCase: true }and reuse it instead of constructing a new object per call🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.