fix: Windows ARM64 update architecture detection#303686
Open
Vinson6688-lee wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: Windows ARM64 update architecture detection#303686Vinson6688-lee wants to merge 1 commit intomicrosoft:mainfrom
Vinson6688-lee wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…updates On Windows ARM64 devices running x64 VS Code under emulation, process.arch returns 'x64' instead of 'arm64', causing the update service to download the wrong architecture version. This fix uses os.arch() to detect the actual OS architecture, ensuring ARM64 devices receive the correct arm64 build regardless of the running process architecture. Fixes issue microsoft#141031
Contributor
|
@Vinson6688-lee please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #141031 where Windows ARM64 devices running x64 VS Code under emulation receive the wrong architecture update.
Problem
On Windows ARM64 devices (e.g., Surface Pro X), when running x64 VS Code under emulation:
process.archreturns 'x64' (the process architecture)Solution
Use
os.arch()instead ofprocess.archto detect the actual OS architecture, ensuring ARM64 devices receive the correct arm64 build regardless of the running process architecture.Changes
getOSArch()helper function to normalize architecture detectioncachePathgetter to usegetOSArch()buildUpdateFeedUrl()to usegetOSArch()Testing
This fix ensures that:
Fixes #141031