Fix: hide Disable globally action when extension is enabled for works…#303698
Open
sohamm20 wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix: hide Disable globally action when extension is enabled for works…#303698sohamm20 wants to merge 1 commit intomicrosoft:mainfrom
sohamm20 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…pace Fixes microsoft#244138 When an extension is globally disabled but enabled for a workspace, the Disable dropdown would incorrectly show both "Disable" and "Disable (Workspace)". This updates DisableGloballyAction's enablement condition to only be enabled when the extension is actually globally enabled.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the Extensions view “Disable” dropdown so it doesn’t offer Disable (global) when an extension is globally disabled but enabled for the current workspace, aligning the actions with the effective enablement state.
Changes:
- Tighten
DisableGloballyActionenablement so it only appears when the extension is actually Enabled Globally.
Author
|
@sandy081 can you review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…pace
Fixes #244138
When an extension is globally disabled but enabled for a workspace, the Disable dropdown would incorrectly show both "Disable" and "Disable (Workspace)". This updates DisableGloballyAction's enablement condition to only be enabled when the extension is actually globally enabled.